review
- Repo stars 357
- Author repo woocommerce-ios
- Domain
- Engineering
- Author-declared agents
- No explicit declaration found; this is not inferred or tested compatibility
- Static check
- 88 / 100 · heuristic scan, not runtime safety proof
- Runtime evidence
- Not run; no isolated runtime test evidence is currently recorded
- Author / version / license
- @woocommerce · no license declared
- Token usage
- Lean
- Setup complexity
- Plug-and-play
- External API key
- Not required
- Operating systems
- Unspecified (assume cross-platform)
- Runtime requirements
- No explicit requirements detected
- Detected file/system behavior
-
- Read-only
- Network behavior
- Local-only
- Install commands
- None (reference only)
Heads up: Tool permissions are not declared; actual access depends on the runtime.
Review the current changes for compliance with WooCommerce iOS conventions.
1. Get the changes to review:
```bash
git diff trunk...HEAD
```
If no diff against trunk, fall back to staged changes: `git diff --cached`
2. Check each modified file against these criteria:
**Architecture** (see `.claude/rules/architecture.md`):
- UI code does not import Networking or Storage directly
- New actions follow the Yosemite dispatch pattern
- Dependencies injected via constructor with protocol types
- Coordinators for navigation, ViewModels for state
**Swift Style** (see `.claude/rules/swift-style.md`):
- No force unwraps or force casts
- Error handling uses do-catch, not try?
- Line length under 163 characters
- No parentheses around conditionals
**Localization** (see `.claude/rules/localization.md`):
- NSLocalizedString uses reverse-DNS keys with value: and comment:
- No LocalizedStringKey
- No string interpolation in localized strings
- Positional placeholders (%1$@)
- Strings grouped in enum Localization { }
**Analytics** (see `.claude/rules/analytics.md`):
- New events added to WooAnalyticsStat
- Properties use WooAnalyticsEvent factory pattern
- Analytics dependency injected
**Testing** (see `.claude/rules/testing.md`):
- New code has corresponding tests
- Tests use snake_case naming
- Given/When/Then structure
- Hand-written mocks with Mock prefix
3. Report findings organized by severity:
- **Blockers**: Must be fixed before merge
- **Suggestions**: Recommended improvements
- **Positives**: Things done well
Sections and files
Listed in source order.
sections -> → → → → Architecture → Swift Style
terms -> Architecture · Swift Style · Localization · Analytics · Testing · Blockers · Suggestions · Positives
files/cmd -> git diff --cached · .claude/rules/architecture.md · .claude/rules/swift-style.md · .claude/rules/localization.md · .claude/rules/analytics.md · .claude/rules/testing.md
body sha256 -> 76307d3e9a0a
Get the changes to review:
If no diff against trunk, fall back to staged changes:
git diff --cachedCheck each modified file against these criteria:
Architecture
(see
.claude/rules/architecture.md): - UI code does not import Networking or Storage directly - New actions follow the Yosemite dispatch pattern - Dependencies injected via constructor with protocol types - Coordinators for navigation, ViewModels for stateSwift Style
(see
.claude/rules/swift-style.md): - No force unwraps or force casts - Error handling uses do-catch, not try? - Line length under 163 characters - No parentheses around conditionals