review

Name: review
Author: woocommerce

Engineering Community

Repo stars 357
Author repo woocommerce-ios

Interpretation is structured for decision-making; original keeps the upstream SKILL.md unchanged.

Decide Fit First

Core job: Review code changes against WooCommerce iOS standards Review the current changes for compliance with WooCommerce iOS conventions…
Best fit: Use it when the task has reusable inputs, steps, and validation criteria rather than a one-off answer.
Avoid forcing it: If the source lacks commands, platform support, or external-service evidence, keep those fields unknown instead of guessing.

Design Intent

Structure: The source has limited section structure, so treat it as an invocation rule: trigger, execution boundary, then validation.
Trigger evidence: Prioritize the author’s wording around when to use it, what context to collect, and what output shape to produce.
Evidence boundary: Author text states facts, repository files prove commands and paths, and Fluxly only adds fit, limits, and usage judgment.

How To Use It

Inputs: Provide target material, scope, expected result, forbidden changes, and validation method.
Invocation: Name review directly; if the source includes slash commands, start with the command and then add task context.
Validation: Start small and check whether the result follows “review” before expanding.

Boundaries And Review

Dependencies: It usually needs no extra API key, so start with a small validation task.
Permissions: Declared permissions include read; ask the agent to state file, command, and rollback boundaries before acting.
Quality bar: A useful result names the deliverable, evidence, and next action. Generic prose means the task needs tighter context.

Review the current changes for compliance with WooCommerce iOS conventions.

Get the changes to review:

git diff trunk...HEAD

If no diff against trunk, fall back to staged changes: git diff --cached

Check each modified file against these criteria:

Architecture (see .claude/rules/architecture.md):

UI code does not import Networking or Storage directly
New actions follow the Yosemite dispatch pattern
Dependencies injected via constructor with protocol types
Coordinators for navigation, ViewModels for state

Swift Style (see .claude/rules/swift-style.md):

No force unwraps or force casts
Error handling uses do-catch, not try?
Line length under 163 characters
No parentheses around conditionals

Localization (see .claude/rules/localization.md):

NSLocalizedString uses reverse-DNS keys with value: and comment:
No LocalizedStringKey
No string interpolation in localized strings
Positional placeholders (%1$@)
Strings grouped in enum Localization { }

Analytics (see .claude/rules/analytics.md):

New events added to WooAnalyticsStat
Properties use WooAnalyticsEvent factory pattern
Analytics dependency injected

Testing (see .claude/rules/testing.md):

New code has corresponding tests
Tests use snake_case naming
Given/When/Then structure
Hand-written mocks with Mock prefix

Report findings organized by severity:
- Blockers: Must be fixed before merge
- Suggestions: Recommended improvements
- Positives: Things done well

Fluxly profile Author and license come from source; runtime, permissions, and network are Fluxly detections or estimates

Fluxly category: Engineering
Author-declared agents: No explicit declaration found; this is not inferred or tested compatibility
Static check: 88 / 100 · heuristic scan, not runtime safety proof
Author / version / license: @woocommerce · no license declared
Fluxly token estimate: Lean
Fluxly setup estimate: Plug-and-play
External API key: No requirement detected
Detected OS requirements: Unspecified
Runtime requirements: Unspecified
Detected file/system behavior: Read-only
Detected network behavior: Local-only
Install commands: None (reference only)

Profile is derived at build time from SKILL.md and install vectors. Subject to drift from author intent.

Heads up: 未限定 allowed-tools，默认拥有全部工具权限。

Output preview review-woocommerce.preview

The current SKILL.md does not define a fixed output example.

SKILL.md SKILL.md

Review the current changes for compliance with WooCommerce iOS conventions.

1. Get the changes to review:
```bash
git diff trunk...HEAD
```
If no diff against trunk, fall back to staged changes: `git diff --cached`

2. Check each modified file against these criteria:

**Architecture** (see `.claude/rules/architecture.md`):
- UI code does not import Networking or Storage directly
- New actions follow the Yosemite dispatch pattern
- Dependencies injected via constructor with protocol types
- Coordinators for navigation, ViewModels for state

**Swift Style** (see `.claude/rules/swift-style.md`):
- No force unwraps or force casts
- Error handling uses do-catch, not try?
- Line length under 163 characters
- No parentheses around conditionals

**Localization** (see `.claude/rules/localization.md`):
- NSLocalizedString uses reverse-DNS keys with value: and comment:
- No LocalizedStringKey
- No string interpolation in localized strings
- Positional placeholders (%1$@)
- Strings grouped in enum Localization { }

**Analytics** (see `.claude/rules/analytics.md`):
- New events added to WooAnalyticsStat
- Properties use WooAnalyticsEvent factory pattern
- Analytics dependency injected

**Testing** (see `.claude/rules/testing.md`):
- New code has corresponding tests
- Tests use snake_case naming
- Given/When/Then structure
- Hand-written mocks with Mock prefix

3. Report findings organized by severity:
   - **Blockers**: Must be fixed before merge
   - **Suggestions**: Recommended improvements
   - **Positives**: Things done well

Evidence boundary and execution chain

Author text anchors workflow facts; Fluxly only indexes current sections, terms, files, and commands.

sections -> no H2/H3 headings
terms    -> Architecture · Swift Style · Localization · Analytics · Testing · Blockers · Suggestions · Positives
files/cmd -> git diff --cached · .claude/rules/architecture.md · .claude/rules/swift-style.md · .claude/rules/localization.md · .claude/rules/analytics.md · .claude/rules/testing.md
body sha256 -> 76307d3e9a0a

Decide Fit First

Design Intent

How To Use It

Boundaries And Review

Discussion