java code reviewer

AI Community

Skill notes

Workflow

Step 1: Identify the package to review Ask the user which instrumentor to review if not already clear from context The package lives under java/instrumentation/openinference-instrumentation-<name>/ Read the instrumentor source, build.gradle, and src/test/ directory Step 2: Use the instrumented library source as ground truth

Section 1: Gradle Setup

Read the instrumentor's build.gradle and the root java/build.gradle. Instrumented library must be compileOnly (not implementation) — High openinference-instrumentation must be api Version constants should be in root ext block, not hardcoded — Medium Module must be in java/settings.gradle — Critical if missing

Exhaustive attribute assertions

This is the most important testing pattern. Tests must verify ALL span attributes, not spot-check a few. The remove-and-verify pattern catches both unexpected additions and silent removals: Missing emptiness check — High.

Other required test coverage

Error handling: exception -> span has StatusCode.ERROR + recorded exception — High Context attribute propagation: session_id, user_id, metadata, tags TraceConfig masking: verify hideInputMessages etc. actually suppress attributes Missing test files entirely — Critical

Section 3: OpenInference Semantic Conventions

Read SemanticConventions.java for the full attribute catalog: java/openinference-semantic-conventions/src/main/java/com/arize/semconv/trace/SemanticConventions.java Also read the spec files under spec/ (semantic_conventions.md, traces.md, llm_spans.md, embedding_spans.md, tool_calling.md) for expected behavior. For the library type being reviewed, verify the instrumentor sets all applicable

Fluxly profile Runtime and permissions are inferred by Fluxly static checks, not author declarations or runtime test results.
Domain
AI
Author-declared agents
No explicit declaration found; this is not inferred or tested compatibility
Static check
88 / 100 · heuristic scan, not runtime safety proof
Runtime evidence
Not run; no isolated runtime test evidence is currently recorded
Author / version / license
@Arize-ai · no license declared
Token usage
Lean
Setup complexity
Plug-and-play
External API key
Not required
Operating systems
Unspecified (assume cross-platform)
Runtime requirements
No explicit requirements detected
Detected file/system behavior
  • Read-only
Network behavior
External requests
Install commands
None (reference only)

Heads up: Tool permissions are not declared; actual access depends on the runtime.

Output preview java-code-reviewer.preview
# Presenting Results

Organize findings into a table: | Severity | Section | Finding | Location | |----------|---------|---------|----------| | Critical | 4 | span.end() not called in error path | `SomeListener.java:142` | | High | 2 | Tests don't verify all span attributes | `SomeTest.java:85` | | ... | ... | ... | ... | Then list what's working well — positive findings help the user understand what doesn't need to change.

Discussion

Powered by GitHub Discussions. Sign in with GitHub to comment, react, or subscribe.